Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Open Folder" menu item on Windows #18855

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

daviwil commented Feb 15, 2019

Identify the Bug

Fixes #18835

Description of the Change

This change fixes an issue introduced by PR #17529 which caused the "File -> Open Folder" menu item to incorrectly launch the "Open File" dialog on Windows. The fix is to send the correct parameter folder to promptForPathToOpen when the application:open-folder command is executed. I've also moved the registration for these event handlers into a macOS-only code block so that they won't be activated on Windows (the original fix was only relevant to Atom instances on macOS where no windows were currently open).

Alternate Designs

None.

Possible Drawbacks

None.

Verification Process

  • Manually verify that the "Open Folder" dialog opens on Windows when clicking "File -> Open Folder"
  • Manually verify that the "File -> Open" dialog still enables files and folders to be opened when no Atom windows are currently open

Release Notes

N/A

@daviwil daviwil referenced this pull request Feb 15, 2019

Closed

"Open Folder" activates "Open File" dialog instead #18835

1 of 1 task complete

@daviwil daviwil force-pushed the dw-fix-open-folder branch from d52982e to bf3502c Feb 15, 2019

@daviwil daviwil added the regression label Feb 15, 2019

@daviwil daviwil merged commit eadb900 into master Feb 15, 2019

3 checks passed

Atom Pull Requests #20190215.9 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-fix-open-folder branch Feb 15, 2019

@bloopletech bloopletech referenced this pull request Mar 12, 2019

Closed

File -> Open Folder displays Open File dialog #18971

0 of 1 task complete

jasonrudolph added a commit that referenced this pull request Mar 12, 2019

Merge pull request #18855 from atom/dw-fix-open-folder
Fix "Open Folder" menu item on Windows

jasonrudolph added a commit that referenced this pull request Mar 12, 2019

Merge pull request #18855 from atom/dw-fix-open-folder
Fix "Open Folder" menu item on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.