Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add linter to packages/ folder #18885
Requirements for Contributing a Bug Fix
Identify the Bug
Linter was not checking the
Description of the Change
The JS code style of the
This PR enables the linter and fixes all the linting issues that appeared on that folder. Most of the issues have been fixed automatically by running
This PR changes a bunch of files, and while
I'm going to manually verify the automatic fixes and rely on the existing automated tests.
N/A (it's only an internal change)
jasonrudolph left a comment
I can't claim to have reviewed every line, but as noted in the PR body, "prettier should only do style changes," so this should be a safe change to merge. And since you're planning to review the non-automatic changes manually to make sure that they're OK, I think this is safe to ship once you've completed your verification.
I've reviewed the automatic changes done by
The failing test is related to