Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add linter to spec/ folder #18896
Identify the Bug
Linter was not checking the
Description of the Change
Note: This PR depends on #18885
The JS code style of the
This PR enables the linter and fixes all the linting issues that appeared on that folder. Most of the issues have been fixed automatically by running
N/A (since this PR only changes test files).
Check that tests keep passing on CI.
N/A (it's only an internal change).
jasonrudolph left a comment
I did not review the automatic fixes, but I did review each of the commits that performed manual fixes. I noted one question inline below, but overall, these changes look good.
referenced this pull request
Feb 26, 2019
Actually with #18917 merged almost all the imports of
That can be saved for another PR though as the same can likely be said for virtually all the specs.
Yup, I'm planning to remove all these imports in a follow-up PR