Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually dump minidump contents to .sym files #18900

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

commented Feb 22, 2019

So... all of the .node.sym files included in atom-mac-symbols.zip artifacts in Atom releases include only the string "undefined." This corrects the build process to actually write the minidump symbol contents to those files.

@smashwilson smashwilson merged commit e87e556 into master Feb 22, 2019

2 of 3 checks passed

Atom Pull Requests #20190222.9 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/actually-dump-symbols branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.