Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ settings-view@0.260.1 #18961

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@jasonrudolph
Copy link
Member

jasonrudolph commented Mar 8, 2019

Upgrade from settings-view v0.260.0 to v0.260.1 [changelog]

Resolves atom/settings-view#1110 and atom/settings-view#1118.

@jasonrudolph jasonrudolph self-assigned this Mar 8, 2019

@rafeca

rafeca approved these changes Mar 8, 2019

Copy link
Contributor

rafeca left a comment

Ups, I forgot to publish a new version of settings-view and upgrade it! Thanks for taking care of it!

@jasonrudolph

This comment has been minimized.

Copy link
Member Author

jasonrudolph commented Mar 8, 2019

The CI status above shows that the Azure Devops Atom Pull Requests build has failed, but it later passed in https://github.visualstudio.com/Atom/_build/results?buildId=35123.

I'm not sure why Azure DevOps isn't reporting the passing build to github.com, but I think we're safe to merge.

@jasonrudolph jasonrudolph merged commit 5f10cdd into master Mar 8, 2019

2 of 3 checks passed

Atom Pull Requests #20190308.1 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the settings-view-0.260.1 branch Mar 8, 2019

jasonrudolph added a commit that referenced this pull request Mar 8, 2019

Merge pull request #18961 from atom/settings-view-0.260.1
⬆️ settings-view@0.260.1

jasonrudolph added a commit that referenced this pull request Mar 8, 2019

Merge pull request #18961 from atom/settings-view-0.260.1
⬆️ settings-view@0.260.1

jasonrudolph added a commit that referenced this pull request Mar 8, 2019

Merge pull request #18961 from atom/settings-view-0.260.1
⬆️ settings-view@0.260.1

jasonrudolph added a commit that referenced this pull request Mar 8, 2019

Merge pull request #18961 from atom/settings-view-0.260.1
⬆️ settings-view@0.260.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.