Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure APM_TEST_PACKAGES may be activated in Jasmine specs #18984

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

commented Mar 13, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

Part of the solution to #18983.

Description of the Change

If the test runner environment of the default Jasmine runner includes APM_TEST_PACKAGES, the packages named there will be symlinked (or, if that fails, copied) to the temporary Atom home used for the current run.

Alternate Designs

@Arcanemagus spelled out some of the other alternatives in #18983. This was the quickest to implement, but should cover the immediate problem. I'm still open to doing the other suggestions (in addition to this one), especially if we hear from more people.

Possible Drawbacks

It's possible that a user has APM_TEST_PACKAGES set in their environment, but doesn't intend to have those packages available to their test suites.

If a user is running apm install to install package prerequisites manually in CI, this will still fail.

Verification Process

  1. Clone AtomLinter/linter-bailey and ran apm ci.
  2. Install language-bailey with apm install language-bailey.
  3. Run the package specs with atom --test spec/.

The specs almost all fail when run with atom 1.37.0-nightly17, or when run with this PR active on the dev resource path without APM_TEST_PACKAGES set, but pass with this PR active and APM_TEST_PACKAGES=language-bailey.

Release Notes

  • The default Jasmine test runner allows you to activate packages listed in APM_TEST_PACKAGES.

smashwilson added some commits Mar 13, 2019

@smashwilson smashwilson merged commit 1cb2ccd into master Mar 14, 2019

3 checks passed

Atom Pull Requests #20190314.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/respect-test-packages branch Mar 14, 2019

@Arcanemagus Arcanemagus referenced this pull request Mar 14, 2019

Merged

V2 Linter API support #11

smashwilson added a commit that referenced this pull request Mar 28, 2019

Merge pull request #18984 from atom/aw/respect-test-packages
Ensure APM_TEST_PACKAGES may be activated in Jasmine specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.