Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language-toml #19047

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

commented Mar 25, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

atom/language-toml#18, atom/language-toml#21

When more than one key/value pair was on the same line, as is valid in inline tables, language-toml would not know when to stop each value.

Description of the Change

language-toml has been refactored to handle cases where more than one key may exist per line (atom/language-toml#21).

(Note: the version was bumped to 0.20.0 from 0.18.2 as there seems to be an extraneous 0.19.0 tag already present in the repo)

Alternate Designs

We could have gone for a tree-sitter rewrite instead.

Possible Drawbacks

Standalone values, which were invalid TOML to begin with, are no longer supported.

Verification Process

New tests were added, as well as verification on existing TOML files.

Release Notes

language-toml now supports inline tables

50Wliu added some commits Mar 25, 2019

@50Wliu 50Wliu merged commit 128e6b0 into master Mar 27, 2019

2 checks passed

Atom Pull Requests #20190327.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-upgrade-language-toml branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.