Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reopen project when there are no open windows #19058

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented Mar 26, 2019

Identify the Bug

Fixes #17530

Description of the Change

This PR adds some logic in the atom application process to handle the reopen commands, so when one of these commands gets triggered without an atom environment it still works.

Alternate Designs

I cannot think about an alternative way of implementing this...

Possible Drawbacks

Cannot identify any.

Verification Process

  1. Close all Atom windows from OSX
  2. Go to File -> Recent Project and open one of the projects listed there.
  3. Open two folders in a single Atom window and close that window.
  4. Go to File -> Recent Project and open the recent project containing the two folders.

Release Notes

Fixed an issue in OSX that prevented File->Reopen Project to work when there were no open windows

@rafeca rafeca self-assigned this Mar 26, 2019

@rafeca rafeca requested a review from jasonrudolph Mar 26, 2019

@rafeca rafeca force-pushed the rafeca:fix-reopen-project branch from 798435e to 9f453e6 Mar 26, 2019

@jasonrudolph
Copy link
Member

left a comment

⚡️

@rafeca rafeca merged commit 2656d4a into atom:master Mar 27, 2019

2 checks passed

Atom Pull Requests #20190326.7 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the rafeca:fix-reopen-project branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.