Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tree-sitter to v0.14.0 #19060

Merged
merged 1 commit into from Apr 7, 2019

Conversation

Projects
None yet
2 participants
@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Mar 27, 2019

This PR bumps the tree-sitter node module to the latest version. The only Tree-sitter changes that affect this module are:

For context, the initial reason behind this ☝️ timeout API is described here; I wanted a way to parse synchronously (within a certain "cutoff") when possible, to prevent unnecessary DOM updates. Previously, the cutoff was specified in fairly arbitrary units, whereas now it's specified as a real time duration, in microseconds. I've set the synchronous parsing cutoff at one millisecond for now, which is the amount of time I was trying to approximate before.

Testing

There haven't been any large code changes, so this should be low risk. But in order to test exhaustively that Tree-sitter is working well in Atom, I plan to do this:

  • Make sure the TreeSitterLanguageMode unit tests pass
  • Get a list of all the grammars that Atom currently bundles
Object.keys(atom.grammars.treeSitterGrammarsById)
  • View and edit some code in each of these languages:

    • source.c
    • source.cpp
    • text.html.basic
    • text.html.ejs
    • text.html.erb
    • source.js
    • source.flow
    • source.ts
    • source.ruby
    • source.css
    • source.go
    • source.jsdoc
    • source.js.regexp
    • source.python
    • source.rust
    • source.shell
@maxbrunsfeld

This comment has been minimized.

Copy link
Contributor Author

maxbrunsfeld commented Mar 29, 2019

Ok, this is ready for review.

@maxbrunsfeld maxbrunsfeld requested review from rafeca and jasonrudolph Mar 29, 2019

@maxbrunsfeld maxbrunsfeld merged commit 386b153 into master Apr 7, 2019

2 checks passed

Atom Pull Requests #20190327.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-0-14 branch Apr 7, 2019

maxbrunsfeld added a commit that referenced this pull request Apr 8, 2019

Revert "Merge pull request #19060 from atom/mb-tree-sitter-0-14"
This reverts commit 386b153, reversing
changes made to 5a4cfeb.

maxbrunsfeld added a commit that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.