Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ fuzzy-finder@1.12.0 #19075

Merged
merged 3 commits into from Apr 1, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented Mar 29, 2019

This version includes an option for using the super-fast fuzzy-native filtering system (more info).


List of changes between fuzzy-finder@1.10.2 and fuzzy-finder@1.12.0: atom/fuzzy-finder@v1.10.2...v1.12.0

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

All builds are failing 😢

My current hypothesis is that electron-link is not able to manage the cyclic dependency in fuzzy-native: https://github.com/atom/fuzzy-native/blob/master/lib/main.js#L4, I'm gonna investigate more

/cc @smashwilson

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

Oh, the error comes from here which throws when processing this line.

I'm gonna try to remove that file from the v8 snapshot...

@rafeca rafeca merged commit b94276c into atom:master Apr 1, 2019

2 checks passed

Atom Pull Requests #20190330.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the rafeca:upgrade-fuzzy-finder branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.