Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update CI scripts to lint early and fail fast #19096
Issue or RFC Endorsed by Atom's Maintainers
This pull request closes #18940.
This pull request also helps us make progress toward #19006.
Description of the Change
This pull request enhances the CI builds to "fail fast" when a linting violation is present, so that developers can enjoy a faster feedback loop. (See #18940 for more discussion of the motivation.)
As @50Wliu mentions in #18940 (comment),
With the changes in this pull request, we now run
It introduces a small bit of additional conditional logic to
To verify these changes, I intentionally inserted a linting violation and confirmed that the builds failed fast. I then removed the linting violation and confirmed that all the builds passed. For more details, please see below.
Note: This pull request doesn't change anything about the AppVeyor build. In the AppVeyor build,
N/A - This is not a user-facing change, so it probably shouldn't go into the release notes.