Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix atom-application tests #19124
When closing a window with a file that does not exist, Atom opens a dialog asking the users if they want to save the changes. This dialog prevents the tests from finishing correctly (as seen in the CI builds).
I still don't know why this test can ever pass (currently it always fails on my OSX machine).
This should fix #18993
It seems that this test passes whenever the following trace is shown on the logs:
So probably a different error is causing Atom to crash and that makes this test pass
This is related to #19089
After further investigation it looks like the error mentioned above is unrelated with this flakiness: the problem is that the test does not wait until Atom has been fully loaded so if Atom loads faster than expected the confirm dialog will be shown and the test will fail.