Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until the editor is ready on application test #19126

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented Apr 9, 2019

This should fix the root issue that made the test that was fixed on #19124 flaky.

The problem is that this specific test was not waiting until the editor was completely ready, so sometimes the confirmation dialog was shown and some other times it wasn't.

This PR add the needed wait to that test. If we find additiional flaky tests in that file we may want to add similar waits.

@rafeca rafeca merged commit b50a570 into master Apr 10, 2019

2 checks passed

Atom Pull Requests #20190409.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the wait-on-app-tests branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.