Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️temp@0.9.0 #19143

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@jasonrudolph
Copy link
Member

commented Apr 11, 2019

This pull request upgrades the temp module from to the latest version (v0.9.0).

This pull request also updates tree-view from v0.225.0 to v0.226.0. The only change in v0.226.0 is an upgrade to temp v0.9.0 (atom/tree-view#1310).

This upgrade might reduce the flakiness described in #18991.


List of changes between temp@0.8.3 and temp@0.9.0: bruce/node-temp@v0.8.3...v0.9.0

jasonrudolph added some commits Apr 11, 2019

@50Wliu

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Yikes, looks like we still have quite a lot of packages using temp@0.8.3 😬

@jasonrudolph

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

Yikes, looks like we still have quite a lot of packages using temp@0.8.3 😬

With this pull request, atom/atom resolves to temp 0.9.0, but you're right: some packages still resolve to 0.8.3 (example).

So, we'll have to see if this pull request helps out with at all with #18991. 🤷‍♂️🤞

@jasonrudolph jasonrudolph merged commit 4a29f44 into master Apr 12, 2019

2 checks passed

Atom Pull Requests #20190412.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jasonrudolph jasonrudolph deleted the temp-0.9.0 branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.