Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try upgrading Tree-sitter for a third time #19172

Merged
merged 5 commits into from May 7, 2019

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Copy link
Contributor

commented Apr 16, 2019

This time, I've configured Travis so that it will run on this branch, so we will be able to tell if the branch breaks the Travis build before merging it.

I still have no idea why this change would affect the main process tests. AFAICT, Tree-sitter is not loaded in any main process test.

See #19060

maxbrunsfeld added some commits Apr 16, 2019

Revert "Revert "Merge pull request #19165 from atom/mb-upgrade-tree-s…
…itter-to-0-14-again""

This reverts commit e10adac.
@maxbrunsfeld

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

The windows failure on Azure looks spurious:

Project
  .onDidChangeFiles()
    it Project .onDidChangeFiles() reports filesystem changes within project paths
      timeout: timed out after 60000 msec waiting for promise to be resolved or rejected

@maxbrunsfeld maxbrunsfeld force-pushed the mb-tree-sitter-upgrade-test-travis branch from 5169fc1 to e33ac81 May 7, 2019

@maxbrunsfeld

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Ok, finally 💚 .

I still don't get why the Travis build was broken by #19060, but I now know that it had something to do with the fact that we started providing pre-built binaries of the Tree-sitter module.

As far as I can tell, something about those prebuilt binaries causes the Travis build to time out on those two integration tests, even though the Azure build has always been fine.

It may have to do with the fact that the Travis build is configured to use clang for C and C++ code, whereas the pre-built tree-sitter binaries were built with gcc. Maybe that caused them to link against different versions of libc or libc++/libstdc++.

For now, I've deleted the Linux Electron artifacts from the tree-sitter release, and it has fixed the issue. I might just stop creating linux binaries for now.

@maxbrunsfeld maxbrunsfeld merged commit fa10086 into master May 7, 2019

3 checks passed

Atom Pull Requests #20190507.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-upgrade-test-travis branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.