Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
On Azure DevOps, upload Windows crash dumps to S3 on release branches #19183
In #19171, I changed the build pipeline to publish Windows crash reports as artifacts on pull requests. As I stated in that PR, because these crash reports contain environment variables, publishing them as artifacts on our release builds would leak secrets such as our S3 credentials.
In this follow-up PR, we upload Windows crash reports produced during release builds to S3 with a
After a test run in which I intentionally crashed the render process, I confirmed that the report was uploaded to S3 with the appropriate permissions:
Here's me fetching the access control list for the uploaded crash report:
Contrast the above ACL to one that makes the object publicly-readable, such as for our ordinary build artifacts. Notice that ACL includes an entry for