Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-upgrade electron-link to v0.3.3 #19200

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

commented Apr 23, 2019

It looks like our electron-link dependency got caught in the downgrade from Electron 3 to Electron 2. electron-link@3.3.0 includes a pretty important startup performance fix, atom/electron-link#16, so we should re-include it ASAP.

馃帺 Hat tip to @rafeca who noticed the performance regression pretty much immediately after coming back from vacation 馃槃

@smashwilson smashwilson merged commit 0cd7020 into master Apr 23, 2019

2 checks passed

Atom Pull Requests #20190423.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smashwilson smashwilson deleted the aw/electron-link-up branch Apr 23, 2019

smashwilson added a commit that referenced this pull request Apr 23, 2019

Merge pull request #19200 from atom/aw/electron-link-up
Re-upgrade electron-link to v0.3.3

smashwilson added a commit that referenced this pull request Apr 23, 2019

Merge pull request #19200 from atom/aw/electron-link-up
Re-upgrade electron-link to v0.3.3

@bittin bittin referenced this pull request May 6, 2019

Closed

1.37 releases #19256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.