Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
"Reopen projects" in a new window #19203
Requirements for Contributing a Bug Fix
Identify the Bug
Description of the Change
I'm reworking the IPC messages that
I could have opted for a more surgical fix within the confines of the existing IPC message structure. The way they were structured was fairly confusing though - we had listeners for
I also considered making
In addition to unit tests, here's my behavior verification matrix.
Given this directory tree:
No open windows
One empty window
One window with a project root
That weird edge case
jasonrudolph left a comment
Thanks for writing this up!
I reviewed the code, and it matches my expectations for how we want things to behave.
I also built this branch locally and manually tested a handful of scenarios, and all of them behaved as advertised.