Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ markdown-preview@0.160.0 #19209

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented Apr 25, 2019

This version includes an upgraded version of the npm library to render markdown (marked) which fixes a bunch of issues.

marked has been upgraded from v0.3.3 (which is more than 4 years old) to the latest version v0.6.2 (which is only 20 days old). The list of changes between these versions is huge!


List of changes between markdown-preview@0.159.25 and markdown-preview@0.160.0: atom/markdown-preview@v0.159.25...v0.160.0

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

The build failure is caused by the following line on markdown-preview: https://github.com/atom/markdown-preview/blob/master/lib/renderer.js#L69

The desctructuring rest param is causing issues with the esprima version used by electron-link. I'm gonna check how difficult is to upgrade it.

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Currently there's no esprima stable version which supports rest destructuring on objects. Support for it landed on master more than two years ago (jquery/esprima@13e5283) but there hasn't been a release with it yet.

I'm going to check using acorn as a parser.

@rafeca rafeca referenced this pull request Apr 25, 2019

Merged

Use acorn for JS parsing #20

2 of 2 tasks complete
@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Using acorn seems to fix the issue (I've sent a PR to electron-link with the fix).

@rafeca rafeca force-pushed the upgrade-markdown-preview branch from 83b7ea1 to 9232dd3 Apr 25, 2019

@rafeca rafeca force-pushed the upgrade-markdown-preview branch from 9232dd3 to 682fa45 Apr 25, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

CI jobs seem to be passing after upgrading electron-link! 🎉

@rafeca rafeca merged commit 436b769 into master Apr 25, 2019

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@rafeca rafeca deleted the upgrade-markdown-preview branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.