Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable external events from workspaceElement test #19234

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented Apr 29, 2019

This PR changes one of the workspaceElement specs to avoid flakiness caused by external DOM events happening while the test is running.

Not sure if this is going to fix #18992 (since the CI tests should run on a headless machine) but it's worth a try (at least it'll fix flakiness happening on developers machines when minimizing the Atom window while the test is running).

@rafeca rafeca merged commit 2a7ddf0 into master Apr 30, 2019

2 checks passed

Atom Pull Requests #20190429.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the improve-flaky-test branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.