Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid AppVeyor build failures due to problem uploading JUnit XML #19243
Description of the Change
As seen in #18994, our AppVeyor builds periodically fail due to problems uploading the JUnit XML output. Since we already have JUnit XML output for all of our builds on Azure DevOps, and since we want to retire AppVeyor and move to Azure DevOps, it seems pragmatic to resolve this issue by removing the JUnit XML processing from the AppVeyor build. This pull request currently takes this approach to resolving #18994.
We could enhance the uploading logic to gracefully ignore errors that occur during upload and/or retry the upload when it fails. However, since we're hoping to migrate off of AppVeyor, this doesn't feel like a particularly productive endeavor.
To verify this, I pushed up a temporary branch with some platform-specific tests that would intentionally fail:
I then ran those tests on Azure DevOps, and verified that the "Tests" tab shows each of these tests:
In other words, any test that was failing on Windows on AppVeyor should also be visible in the Windows output on Azure DevOps, so I don't think we're losing any meaningful functionality by removing the JUnit XML support on AppVeyor.
smashwilson left a comment
Redundancy with Azure isn't everything -- we have seen tests that fail here and not on Azure and vice versa, for whatever reason. (Isn't CI fun?) But I think we can deal with a bit of scrolling until we can move fully off of AppVeyor.