Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Default to @atom/notify for file system notifications #19244
Description of the Change
The library that we are currently using for file system notifications (
We've already forked
There's an open pull request that enables this option by default, and my first reaction upon encountering the inexplicable crashes from
This leaves us in a difficult position. We need a stable, cross-platform provider of file system notifications to drive several critical aspects of Atom's UI and to support the
This PR aims to provide an alternative. I built a new module for file system notifications called
@nathansobo: A fantastic write-up, as always.
Today I investigated what happens when a watched directory itself is removed or renamed. At least on macOS,
In attempting to test rename logic, I discovered that the
At this point, I see the following paths forward:
I'm leaning toward option 2. The primary use case for
Okay, I'm not sure how I've gotten any green builds before (you can see from the record that they did exist!), but I'm now getting failures due to the GitHub package making assumptions about
I'm going to explore using Windows APIs to normalize to the 8.3-compatible paths in the Rust subprocess and see how we do.
Okay. Green build. Going to wait to merge this until after the next release cycle which should occur early next week. That will maximize our time to test the new notification backend on nightly and beta before it goes to stable. Worst case scenario, we change the default while dealing with anything unforeseen.