Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to @atom/notify for file system notifications #19244

Merged
merged 29 commits into from May 11, 2019
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
89a7aa8
Default to @atom/notify for file system notifications
nathansobo Apr 30, 2019
b49e399
:arrow_up: @atom/notify@1.0.1
nathansobo Apr 30, 2019
781cb90
Fix lint error
nathansobo Apr 30, 2019
90ec3e0
:arrow_up: @atom/notify@1.0.2
nathansobo May 1, 2019
f9d9ed8
Remove top-level construction of a notify Watcher
nathansobo May 1, 2019
cf05317
Eliminate references to undefined watcher variable
nathansobo May 1, 2019
b313b94
Shim onDidError method on returned watcher
nathansobo May 1, 2019
508b56d
Remove logic supporting dynamic switching of path watcher backends
nathansobo May 1, 2019
9b39eea
Fix lint errors 🙈
nathansobo May 2, 2019
6ea9a15
:arrow_up: @atom/notify@1.0.3
nathansobo May 2, 2019
f8d7c9c
Use async/await in test to see if it fixes Windows failures on CI
nathansobo May 2, 2019
da52d16
Prompt to restart Atom when the file system watcher setting changes
nathansobo May 2, 2019
1ec8e77
Work around 8.3 path issue on Azure Windows
nathansobo May 3, 2019
5bfbdd2
Stop all watchers before attempting to replace directory with file
nathansobo May 3, 2019
932aaac
:arrow_up: @atom/notify@1.0.5 to explicitly unwatch on kill
nathansobo May 3, 2019
25083da
:arrow_up: @atom/notify@1.0.6 to kill notify subprocess on parent exit
nathansobo May 6, 2019
1d1b450
:arrow_up: @atom/notify@1.1 for improved error handling
nathansobo May 6, 2019
f1bb55d
Throw exceptions when there are @atom/notify watcher errors
nathansobo May 7, 2019
db40641
Merge remote-tracking branch 'origin/master' into ns/notify
nathansobo May 7, 2019
bfdb1fa
Enable 'poll' option for @atom/notify-based fs watching
nathansobo May 8, 2019
6da489e
Default to 'native' watcher on the stable channel just to be safe
nathansobo May 8, 2019
5366614
Revert "Default to 'native' watcher on the stable channel just to be …
nathansobo May 8, 2019
58dece3
:fire: unused methods
nathansobo May 9, 2019
e58d52e
Add clarifying assertion to test script
nathansobo May 9, 2019
07c08d7
:arrow_up: @atom/notify@1.2.1 for better path handling on Windows
nathansobo May 9, 2019
b1b1b15
Normalize %TEMP% to a long path on Windows CI
nathansobo May 10, 2019
9a176f6
Test everything on Windows
nathansobo May 10, 2019
be7d129
Normalize to realpath in waitForEvents helper
nathansobo May 10, 2019
1d2878f
Merge remote-tracking branch 'origin/master' into ns/notify
nathansobo May 10, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

⬆️ @atom/notify@1.0.3

  • Loading branch information...
nathansobo committed May 2, 2019
commit 6ea9a15d68a7125b2f439af3b84be5cb8141fab4

Some generated files are not rendered by default. Learn more.

@@ -14,7 +14,7 @@
"license": "MIT",
"electronVersion": "2.0.18",
"dependencies": {
"@atom/notify": "1.0.2",
"@atom/notify": "1.0.3",
"@atom/nsfw": "1.0.18",
"@atom/source-map-support": "^0.3.4",
"@atom/watcher": "1.3.1",
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.