Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not wait until config watcher is ready in order to launch the Atom window #19246
nathansobo left a comment
I'm concerned about this introducing a race condition where we don't catch config file changes that occur just after the window starts up. Does it make sense to skip the
How can we remember to revisit this change once we upgrade Electron and see if it's still an issue?
I can do that! I'm not super happy about this solution tbh... it's one of these things where we trade off correctness to overcome a performance issue... hopefully we get rid of this on Electron v3 (I can also abandon this change and just claim the perf improvement when we do the upgrade, but it seemed like a small change to get some perf improvements without having to wait for the big upgrade).
What do you think about what I suggested in #19242 (comment) ?