Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the timeout for the FileRecoveryService tests #19257

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented May 3, 2019

This PR increases the timeout of the FileRecovery tests to 10s, so we don't get the weird timeouts that have started occurring on Linux recently.

This fixes #19235

@rafeca rafeca force-pushed the increase-timeout-file-recovery-test branch 2 times, most recently from d1d4774 to 8b8e71a May 3, 2019

@rafeca rafeca marked this pull request as ready for review May 3, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

I'm gonna run the CI tests for this PR a few times to make sure that the test does not timeout anymore.

In order to verify that this PR reduces the flakiness, I'm hoping to see a few tests that take longer than 2s to execute but less than 10s (example of test result).

@rafeca rafeca force-pushed the increase-timeout-file-recovery-test branch from 8b8e71a to f9b1126 May 3, 2019

@rafeca rafeca force-pushed the increase-timeout-file-recovery-test branch from f9b1126 to fb79283 May 3, 2019

@rafeca rafeca merged commit 0d80191 into master May 6, 2019

2 checks passed

Atom Pull Requests #20190506.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the increase-timeout-file-recovery-test branch May 6, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

I've run half a dozen of CI builds with this PR and haven't seen any test failure, so it's good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.