Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Atom for the electron v3 upgrade #19274

merged 4 commits into from May 7, 2019


None yet
2 participants
Copy link

commented May 6, 2019

This PR cherry picks a subset of the commits found in #18603 that can be easily added to master now before we do the actual migration to electron v3.

daviwil and others added some commits Jan 3, 2019

Make invalid JS file fail Babel spec again
This change uses a different JavaScript syntax to cause the "when a .js file
does not start with 'use babel'" spec to fail again after upgrading to Electron
3 / Node 10.3.0.  The previous generator syntax seems to be supported in the
version of V8 used by Node 10 so we now need to use the 'export default' syntax
to trigger an error.

I've verified that changing the first line of this file to 'use babel' causes
the file to load successfully, so it seems this new syntax is effective to
verify the desired behavior.
Update StyleManager specs to address deprecated ::shadow selectors
As of Chromium 63, ::shadow CSS selectors have been fully removed:

As a result, any usage of ::shadow in a stylesheet seems to get removed as soon
as the stylesheet is applied to an HTMLStyleElement.  Since we have a couple of tests
that expect ::shadow selectors to be present, we must remove those expectations
since those selectors do not appear any longer.

@rafeca rafeca merged commit 833cdd0 into master May 7, 2019

2 checks passed

Atom Pull Requests #20190506.10 succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded

@rafeca rafeca deleted the prepare-for-electron-v3 branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.