Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Prepare Atom for the electron v3 upgrade #19274

Merged
merged 4 commits into from May 7, 2019
Merged

Commits on May 6, 2019

  1. Make invalid JS file fail Babel spec again

    This change uses a different JavaScript syntax to cause the "when a .js file
    does not start with 'use babel'" spec to fail again after upgrading to Electron
    3 / Node 10.3.0.  The previous generator syntax seems to be supported in the
    version of V8 used by Node 10 so we now need to use the 'export default' syntax
    to trigger an error.
    
    I've verified that changing the first line of this file to 'use babel' causes
    the file to load successfully, so it seems this new syntax is effective to
    verify the desired behavior.
    daviwil authored and rafeca committed May 6, 2019
    Copy the full SHA
    3bd2279 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    614d3e1 View commit details
    Browse the repository at this point in the history
  3. Update StyleManager specs to address deprecated ::shadow selectors

    As of Chromium 63, ::shadow CSS selectors have been fully removed:
    
    https://developers.google.com/web/updates/2017/10/remove-shadow-piercing
    
    As a result, any usage of ::shadow in a stylesheet seems to get removed as soon
    as the stylesheet is applied to an HTMLStyleElement.  Since we have a couple of tests
    that expect ::shadow selectors to be present, we must remove those expectations
    since those selectors do not appear any longer.
    daviwil authored and rafeca committed May 6, 2019
    Copy the full SHA
    78f354a View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    a7af6c7 View commit details
    Browse the repository at this point in the history