Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove all listeners in Electron v3 #19275

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented May 6, 2019

This PR contains the isolated commit that was part of the old upgrade to electron v3 PR plus code comments to remember to remove the temporary logic once we upgrade to electron v4

daviwil and others added some commits Jan 17, 2019

Remove listeners for specific events in Task class
This change is necessary for Electron 3 to a bug in Node.js 10.2.x which causes
the `removeAllListeners` method to no longer remove all listeners for any event
name when no argument is passed:

nodejs/node#20924

This issue has been fixed in Node.js 10.3.0+ so we will have to remove this
workaround when we move to Electron 4.0 to avoid future event handler leaks.

@rafeca rafeca merged commit 5302cf9 into master May 7, 2019

2 checks passed

Atom Pull Requests #20190506.17 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the fix-remove-all-listeners branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.