Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate src/initialize-application-window.js #19277

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented May 7, 2019

After merging #19270 we realized that it broke nightly builds because when using asar archives the coffeescript files get transpiled to js and renamed, so the resolution does not work anymore.

The easiest and cleanest way to fix this is by decaffeinating this file, so it always has the js extension (it's a short and relatively simple file to decaffeinate).

@rafeca rafeca force-pushed the decaffeinate-initialize-application-window branch 4 times, most recently from 4bdb3ce to 003b46b May 7, 2019

@rafeca rafeca force-pushed the decaffeinate-initialize-application-window branch from 003b46b to 1efa4f3 May 7, 2019

@rafeca rafeca merged commit a6382d7 into master May 7, 2019

2 checks passed

Atom Pull Requests #20190507.9 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the decaffeinate-initialize-application-window branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.