Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atom.open() when it has no arguments #19280

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented May 7, 2019

This fixes #19265. The root cause was an undefined variable (window).

Not passing any window object to promptForPathToOpen() seems to work correctly (at least on OSX).

@smashwilson
Copy link
Member

left a comment

👍

@rafeca rafeca merged commit e192773 into master May 7, 2019

2 checks passed

Atom Pull Requests #20190507.12 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the fix-atom-open branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.