Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ electron-packager@12.2.0 #19318

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
3 participants
@rafeca
Copy link
Contributor

commented May 13, 2019

This PR updates the version of electron-packager used by Atom to almost the latest one (latest one is 13.0.1 but I thought it would be sensible to use the previous major, which has many more minor and patch releases under its belt).

The main reason for the update is to prepare for a future Electron v4 upgrade which will require electron-userland/electron-packager#894 to be able to work (I found that while exploring to upgrade to Electron v4 directly).

Since the new version of electron-packager should be compatible with both electron v2 and v3, better to upgrade right now (and find potential issues now) than when doing the electron upgrade.

The list of changes between v7.3.0 and v12.2.0 is huge (v7.3.0 is a 3 year old version), so the easier way to get a glimpse of the big changes is to look at its releases page.


List of changes between electron-packager@7.3.0 and electron-packager@12.2.0: electron-userland/electron-packager@v7.3.0...v12.2.0

@rafeca rafeca merged commit fee2af5 into master May 13, 2019

2 checks passed

Atom Pull Requests #20190513.2 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the upgrade-electron-packager branch May 13, 2019

@50Wliu

This comment has been minimized.

Copy link
Member

commented May 13, 2019

fyi there were a few more changes made in the PR to upgrade to 11.x by the author of electron-packager: #15431
Not sure if they're necessary or not.

@malept

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

They're not necessary, but they do clean up the packaging code a lot.

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Oh thanks for the heads up @50Wliu ! Didn't know that that PR existed! I'm gonna cherry pick the relevant changes from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.