Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cached-run-in-this-context dependency #19322

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented May 13, 2019

This PR cherry-picks two of the commits from the electron v3 upgrade to be able to merge them into master before doing the actual upgrade (and lower the risk of the upgrade).

The two commits replace the cached-run-in-this-context by the raw vm APIs. I don't have much context about the reasons of this change, but it may have to do with the comments on atom/cached-run-in-this-context#2 :

We weren't able to conclusively tell that this module was speeding up compilation. When we upgrade Atom to use Electron 3, we should experiment with disabling the NativeCompileCache altogether to see whether this module is still helping us.

/cc @maxbrunsfeld , @daviwil for more context

David Wilson and others added some commits Jan 11, 2019

@rafeca rafeca merged commit 0994d8a into master May 14, 2019

2 checks passed

Atom Pull Requests #20190513.5 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the remove-cached-run-in-this-context branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.