Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate packager improvements from https://github.com/atom/atom/pull/15431 #19324

Merged
merged 8 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented May 13, 2019

This PR is a follow-up of #19318 to integrate the changes made by @malept on #15431

out: CONFIG.buildOutputPath,
overwrite: true,
platform: process.platform,
// Atom doesn't have devDependencies, but if prune is true, it will delete the non-standard packageDependencies.

This comment has been minimized.

Copy link
@rafeca

rafeca May 13, 2019

Author Contributor

That's actually really cool! @malept does this mean that if we enable this option we can start using devDependencies on the top-level package.json without adding them to the app package? 😍

/cc @nathansobo , @smashwilson , @jasonrudolph

This comment has been minimized.

Copy link
@malept

malept May 13, 2019

Contributor

As I mentioned in the comment, packageDependencies is still problematic (i.e., gets pruned) if prune: true is set. If Packager needs to deal with this use case, we'd have to do some refactoring of how pruning works (that is, add support for custom *Dependencies in package.json to be whitelisted).

This comment has been minimized.

Copy link
@rafeca

rafeca May 13, 2019

Author Contributor

Oh, I understood the comment incorrectly, thanks for clarifying 👍

@rafeca rafeca changed the title Integrate improvements from https://github.com/atom/atom/pull/15431 Integrate packager improvements from https://github.com/atom/atom/pull/15431 May 13, 2019

@rafeca rafeca merged commit 1edf94a into master May 13, 2019

2 checks passed

Atom Pull Requests #20190513.7 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the pr/15431 branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.