Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace new Buffer() with Buffer.from() #19339

merged 1 commit into from May 15, 2019


None yet
1 participant
Copy link

commented May 15, 2019

The Buffer constructor got deprecated in Node v10, so in order to get rid of deprecation warnings in the electron-3 branch we need to replace these by Buffer.from() calls.

馃崘'd with @as-cii

Replace new Buffer() with Buffer.from()
This removes deprecation warnings on Node >=10

Co-Authored-By: Antonio Scandurra <>

@rafeca rafeca merged commit 216404d into master May 15, 2019

2 checks passed

Atom Pull Requests #20190515.5 succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded

@rafeca rafeca deleted the remove-deprecated-buffer branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.