Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate default-directory-searcher.coffee and its spec #19347

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented May 16, 2019

This PR decaffeinates the default-directory-searcher.coffee file and its spec. @nathansobo and I started doing this for the ripgrep initiative as we thought it was a needed but later found out it wasn't. Still, it's good to decaffeinate files 馃槃

馃崘'd with @nathansobo

nathansobo and others added some commits May 8, 2019

Decaffeinate default-directory-searcher.coffee and its spec
Co-Authored-By: Rafael Oleza <rafeca@users.noreply.github.com>
@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

The build failure is from a flaky test, since it has nothing to do with the PR changes:

Project
  serialization
    it does not deserialize paths that are now files
      Error: EPERM: operation not permitted, open 'C:\Users\appveyor\AppData\Local\Temp\1\atom-spec-project2019416-1948-4d1zsg.6uigc\child'
        at Object.fs.openSync (fs.js:646:18)
        at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:166:20)
        at Object.fs.writeFileSync (fs.js:1303:33)
        at Proxy.writeFileSync (C:\projects\atom\node_modules\fs-plus\lib\fs-plus.js:292:17)
        at jasmine.Spec.it (C:\projects\atom\spec\project-spec.js:77:10)
        at <anonymous>

So I'm going to merge this PR

@rafeca rafeca merged commit b79d908 into master May 16, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Atom Pull Requests #20190516.2 succeeded
Details

@rafeca rafeca deleted the decaffeinate-default-directory branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.