Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo integration of @atom/notify #19352

Merged
merged 4 commits into from May 17, 2019

Conversation

@nathansobo
Copy link
Contributor

commented May 17, 2019

As I've noted elsewhere, it turns out that switching our underlying notification system was a mistake. This PR reverts the original PR #19244 and a few follow-up PRs that fixed issues on with the ASAR bundle (#19325) and V8 snapshots (#19331). It also reverts the PR that switches the default back to nsfw, since reverting the other PRs rendered that unnecessary. Sorry for the churn everybody.

nathansobo added some commits May 17, 2019

Revert "Merge pull request #19345 from atom/ns/notify-retreat"
This reverts commit 3d37651, reversing
changes made to e1a5d52.
Revert "Merge pull request #19331 from atom/ns-as/notify-snapshot-exc…
…lude"

This reverts commit 1e08ad8, reversing
changes made to 0994d8a.
Revert "Merge pull request #19325 from atom/ns/notify-asar-exclude"
This reverts commit da8b1a1, reversing
changes made to 1edf94a.
Revert "Merge pull request #19244 from atom/ns/notify"
This reverts commit b2ecabd, reversing
changes made to c3bf951.
@rafeca

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

Let's see if this fixes the test failures that we're seeing on master (link).

@nathansobo

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

I think it's likely, because I touched that code path to deal with the watched directory being locked.

@nathansobo nathansobo merged commit fb961df into master May 17, 2019

2 checks passed

Atom Pull Requests #20190517.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nathansobo nathansobo deleted the ns/undo-notify branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.