Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Update .deb package dependencies #19358
Requirements for Contributing a Bug Fix
Identify the Bug
First reported in atom/ci#90, it seems that we aren't reporting the correct dependencies list in our
Description of the Change
The first point there is a mistake that definitely should be requested. The latter two removals of
One of the removed dependencies may actually be required, leading to systems that don't have them installed from some other source having issues running Atom without manual installation of the dependencies first.
I manually ran through the dependencies that would be generated by electron-installer-debian for an Electron 2.x application and came up with the following list:
Excluding the dependencies listed in that for a generic Electron application we are left with:
After reviewing the list of dependencies and making the changes in this PR I ran through the build process manually in an
This has not been tested in a full Debian based linux distribution, only minimal ones within Docker!