Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #19371

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
2 participants
@as-cii
Copy link
Member

commented May 20, 2019

This pull request fixes some deprecation warnings we were observing in our test suite, as well as when opening packages that registered protocol handlers such as the welcome package.

The warnings were due to using the fs.(l)statSyncNoException API, which will be deprecated from Electron 4 onwards. We had already dealt with this by shipping atom/fs-plus#46, which provided a shim on fs-plus to suppress the warning. However, AtomProtocolHandler was still using the standard fs module, which was causing the warning to be displayed whenever a package registered a URL opener.

With these changes, we will now require fs-plus instead of fs in AtomProtocolHandler, thus using the shimmed API that does not emit a deprecation warning.

/cc: @jasonrudolph @50Wliu @rafeca

Use fs-plus instead of fs in AtomProtocolHandler
This commit fixes some deprecation warnings we were observing in our 
test suite, as well as when opening packages that registered protocol 
handlers such as the `welcome` package.

The warnings were due to using the `fs.(l)statSyncNoException` API, 
which will be deprecated from Electron 4 onwards. We had already dealt 
with this by shipping atom/fs-plus#46, which 
provided a shim on `fs-plus` to suppress the warning. However, 
`AtomProtocolHandler` was still using the standard `fs` module, which 
was causing the warning to be displayed whenever a package registered a 
URL opener.

@nathansobo nathansobo merged commit 55ddf0a into master May 20, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nathansobo nathansobo deleted the as/electron-3-deprecations branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.