Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoflow: Do not reflow selections that contain only LaTeX tags #19396

Merged
merged 3 commits into from Jun 10, 2019

Conversation

@50Wliu
Copy link
Member

commented May 23, 2019

Requirements for Contributing a Bug Fix

Identify the Bug

Fixes #19351

Description of the Change

  1. The while loops may empty out the array. In that case, we don't want to keep looking - only continue the while loops as long as there are elements in the array.
  2. If blockLines is empty after the while loops, push the block verbatim (nothing to reflow; only tags) and continue onto the next paragraph.

Alternate Designs

None.

Possible Drawbacks

None.

Verification Process

I've added a spec and made sure that it passes with this change (it fails without it).

Release Notes

Fixed an issue where reflowing a selection consisting solely of LaTeX tags would throw an exception.

50Wliu and others added some commits May 23, 2019

@nathansobo
Copy link
Contributor

left a comment

Nice work tracking this down!

@nathansobo

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

The Azure failures are spurious and have nothing to do with autoflow. I'm going to proceed. Thanks again!

@nathansobo nathansobo merged commit 93f0184 into master Jun 10, 2019

1 of 2 checks passed

Atom Pull Requests #20190531.7 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nathansobo nathansobo deleted the wl-autoflow-latex-tags branch Jun 10, 2019

@nathansobo nathansobo self-assigned this Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.