Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webdriverio #19397

merged 31 commits into from May 31, 2019


None yet
3 participants
Copy link

commented May 23, 2019

Experimental PR to upgrade webdriverio. It's been bothering me for some time that script's package-lock.json keeps deciding to flip-flop between whether or not boom and hoek are required or not, and it just so happens that newer versions of webdriverio no longer depend on them.

50Wliu added some commits May 23, 2019


@50Wliu 50Wliu marked this pull request as ready for review May 26, 2019

@50Wliu 50Wliu changed the title WIP: Upgrade webdriverio Upgrade webdriverio May 26, 2019

@nathansobo nathansobo referenced this pull request May 28, 2019


Upgrade to Electron 4 #19373

4 of 6 tasks complete

as-cii approved these changes May 31, 2019

Copy link

left a comment

This looks good to me, @50Wliu! Thanks for taking this on.

Would you mind fixing the conflicts in script/package-lock.json? After that, I think you can go ahead and merge this! 👍


This comment has been minimized.

Copy link

commented May 31, 2019

Hey!! 👋

We have recently started using prettier and this has caused major style changes on the Atom JS codebase (you can check the related PR).

This is good news: now the Atom code is more consistent and it's much easier to re-format the code to
follow the code style (now you only need to run script/lint --fix).

This change caused conflicts on your PR that we have automatically solved, hope you don't mind 😄

With ❤️, the Atom team.


This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

These changes only affect macOS, so I am merging despite the two Windows failures (flaky spec and build error).

@50Wliu 50Wliu merged commit a7a7056 into master May 31, 2019

0 of 2 checks passed

Atom Pull Requests #20190531.6 failed
continuous-integration/appveyor/pr AppVeyor build failed

@50Wliu 50Wliu deleted the wl-upgrade-webdriverio branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.