Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade atom-keymap to incorporate changes to keyboard-layout #19405

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
1 participant
@nathansobo
Copy link
Contributor

commented May 24, 2019

In atom/keyboard-layout#51, @MarshallOfSound made some behavior-preserving changes to make the keyboard-layout module context-aware. I wanted to get that PR merged for him, and I also want to keep Atom up-to-date. This PR is to ensure we build green against the updated dependency. Once we get a green build I will publish non prerelease versions of atom-keymap and keyboard-layout.

@nathansobo nathansobo force-pushed the ns/upgrade-keymap branch from cf7378a to 7ec394f May 24, 2019

@nathansobo

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

The latest commit is identical to the previous green build, just not depending on a pre-release. I wanted to see dependencies install cleanly, but there's no reason this should fail. Going to merge.

@nathansobo nathansobo merged commit 4b97f7b into master May 24, 2019

1 of 2 checks passed

Atom Pull Requests in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nathansobo nathansobo deleted the ns/upgrade-keymap branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.