This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Enable eslint rules that got disabled #19408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changed codepath seems to be an unintentional mistake which was added in 5c1a49f I cannot see any reason to set a default argument to itself: this is going to cause a ReferenceError when calling that function without that argument and I guess if that was the intended behaviour the author would have added an explicit check at the beginning of the function (or at least a comment).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #19302, a few
eslintrules were disabled to keep that PR small and manageable, now it's the time to enable a few of them.There are two rules that I haven't enabled:
standard/no-callback-literal: We have quite a few Atom public APIs that expect a callback with the result on the first argument, so to enable this rule we would have to either add a bunch ofignorecomments or to create a quite big breaking change.node/no-deprecated-api: This is a quite useful rule, but I haven't been able to enable it because it complains about usingurl.parse(). Changing this to the newURL()constructor would be a breaking change, since we're passingurlobjects to packages.We can follow-up what to do for these two rules in separate PRs, to keep the discussion focused.