Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Improvements to ripgrep scanner #19444
This PR includes support for a few options that were ignored on the initial PR that added support for using
List of options:
We did not catch this because there was no test checking them, so I've added tests for each of them to ensure that we don't add regressions in the future.
I've noticed that the
I'll check how can we fix the scenario 3 (it may require bigger changes) and send a follow-up PR.
This is probably related to the fact that we search within gitignored folders any time an explicit path is specified. That behavior is actually really annoying. The perfect fix would be to detect when the user was explicitly specifying a gitignored folder, but is probably more work than whatever Scandal is doing.
There were CI failures on this PR for Windows, caused by the test that I added for this specific behaviour.
After testing it locally, it seems that even the behaviour from