Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update apm to remove node-gyp logic #19482
Template does not apply - this is a package version bump.
See atom/apm#845 for the majority of the details. We now delegate to npm to handle Electron header installation rather than trying to do it ourselves through node-gyp.
2.3.0 also contains a Node version bump to 10.2.1, in order to match Electron 3.
Yep! I have a fix locally and will push it tonight.
Background as to why this is happening:
I'm confused as to how node-gyp is picking up on the correct Electron version but not the dist URL (is it only picking up a subset of the flags we pass to npm?), but specifying all of these options using environment variables seems to work, so that's my fix.