Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store null buffers on the cacheStore #19491

Merged
merged 1 commit into from Jun 12, 2019

Conversation

@rafeca
Copy link
Contributor

commented Jun 11, 2019

It looks like the cachedData property of vm.Script() (more info) in Node v10 is assigned to undefined instead of null whenever it can't be computed.

This is causing issues when trying to store the data between reloads and produces a TypeError (more info in the reporting issue). I'm not sure if this can be causing performance regressions due to not being able to cache some compiled files output...

This fixes #19430

@rafeca rafeca merged commit 0226ae9 into master Jun 12, 2019

2 checks passed

Atom Pull Requests #20190611.5 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the fix-compilation-cache-issue branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.