Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store null buffers on the cacheStore #19491

merged 1 commit into from Jun 12, 2019
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -43,7 +43,7 @@ class NativeCompileCache {
const script = new vm.Script(code, { filename, produceCachedData: true });
return {
result: script.runInThisContext(),
cacheBuffer: script.cachedData
cacheBuffer: script.cachedDataProduced ? script.cachedData : null

@@ -102,7 +102,7 @@ class NativeCompileCache {
console.error(`Error running script ${filename}`);
throw err;
if (compilationResult.cacheBuffer !== null) {
if (compilationResult.cacheBuffer) {
self.cacheStore.set(cacheKey, compilationResult.cacheBuffer);
compiledWrapper = compilationResult.result;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.