Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js version used in CI systems #19504

Merged
merged 2 commits into from Jun 12, 2019

Conversation

@rafeca
Copy link
Contributor

commented Jun 12, 2019

After the upgrade to Electron v3 Atom's codebase runs on Node v10.2.0, so upgrading the CI systems to also use the same Node.js version brings consistency (in terms of language features) and can also impact on build speed improvements (although these may be minor).

This PR updates the Node.js version to v10.2.1 (we cannot update to v10.2.0 since there are build failures caused by nodejs/node#20921).

@rafeca rafeca force-pushed the update-node-ci-version branch 3 times, most recently from 4f6dccb to 683705c Jun 12, 2019

@rafeca rafeca requested review from as-cii, jasonrudolph and nathansobo Jun 12, 2019

rafeca added some commits Jun 12, 2019

Update the nodejs version used on CI systems
It now matches the version of Node.js that Electron v3.1 is using.
Add yml files to the node_modules cache key
This is to prevent reusing the node_modules folder when there are
changes in the build system, which can affect the npm install step (like
upgrading the Node.js version).

@rafeca rafeca force-pushed the update-node-ci-version branch 2 times, most recently from a56f33a to 8d9a7aa Jun 12, 2019

@as-cii

as-cii approved these changes Jun 12, 2019

Copy link
Contributor

left a comment

Looks good to me! 👍

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Some warnings appear both when installing the npm dependencies on the script/ and on the root folder.

Some of these warnings already appear on master, it's just that upgrading Node.js has added a few more. We should fix them at some point.

Root folder

ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation are out of sync. Falling back to library file for linking.
../src/main.cc:26:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(1, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/main.cc:46:24: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string command(*String::Utf8Value(info[0]));
                       ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/main.cc:63:33: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
    args.push_back(std::string(*String::Utf8Value(js_arg)));
                                ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
3 warnings generated.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
added 1090 packages in 101.01s
Installing apm
../src/onig-scanner.cc:61:23: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
    String::Utf8Value utf8Value(sources->Get(i));
                      ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
1 warning generated.
../src/onig-scanner-worker.cc:37:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/onig-scanner-worker.cc:43:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
2 warnings generated.
../src/onig-string.cc:26:5: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  : utf8Value(value), utf8_length_(utf8Value.length()) {
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/onig-string.cc:33:19: warning: 'Value' is deprecated [-Wdeprecated-declarations]
    String::Value utf16Value(value);
                  ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2846:5: note: 'Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version", explicit Value(Local<v8::Value> obj));
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/onig-string.cc:30:40: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  hasMultiByteChars = (value->Length() != utf8_length_);
                       ~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
3 warnings generated.
../deps/libgit2/deps/zlib/inflate.c:1507:61: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
    if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
                                                        ~~~ ^
1 warning generated.
../src/repository.cc:86:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string path(*String::Utf8Value(args[0]));
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:230:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string path(*String::Utf8Value(info[0]));
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:248:23: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
    std::string path(*String::Utf8Value(info[0]));
                      ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:269:26: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string configKey(*String::Utf8Value(info[0]));
                         ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:292:26: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string configKey(*String::Utf8Value(info[0]));
                         ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:293:28: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string configValue(*String::Utf8Value(info[1]));
                           ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:322:23: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
    std::string path(*String::Utf8Value(info[0]));
                      ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:354:23: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
    String::Utf8Value utf8Path(pathsArg->Get(i));
                      ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:386:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  String::Utf8Value utf8Path(info[0]);
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:406:24: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string refName(*String::Utf8Value(info[0]));
                       ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:451:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  String::Utf8Value utf8Path(info[0]);

script/ folder

ode/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:512:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string path(*String::Utf8Value(info[0]));
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:558:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string path(*String::Utf8Value(info[0]));
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:619:29: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string fromCommitId(*String::Utf8Value(info[0]));
                            ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:624:27: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string toCommitId(*String::Utf8Value(info[1]));
                          ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:648:28: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string commitOneId(*String::Utf8Value(info[0]));
                           ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:653:28: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string commitTwoId(*String::Utf8Value(info[1]));
                           ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:684:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string text(*String::Utf8Value(info[1]));
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:757:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string text(*String::Utf8Value(info[1]));
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:888:27: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string strRefName(*String::Utf8Value(info[0]));
                          ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:933:21: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string path(*String::Utf8Value(info[0]));
                    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/repository.cc:968:31: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  std::string repositoryPath(*String::Utf8Value(path));
                              ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/vsts/.node-gyp/10.2.1/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
22 warnings generated.
../src/onig-scanner-worker.cc:37:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/onig-scanner-worker.cc:43:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
2 warnings generated.
../src/onig-string.cc:30:40: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  hasMultiByteChars = (value->Length() != utf8_length_);
                       ~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
1 warning generated.
../deps/libgit2/deps/zlib/inflate.c:1507:61: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
    if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
                                                        ~~~ ^

@rafeca rafeca merged commit 442549e into master Jun 12, 2019

2 checks passed

Atom Pull Requests #20190612.17 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the update-node-ci-version branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.