Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade find-and-replace@0.218.13 #19505

Merged
merged 1 commit into from Jun 12, 2019

Conversation

@as-cii
Copy link
Contributor

commented Jun 12, 2019

Fixes #19480
Refs atom/find-and-replace#1090

This pull request upgrades find-and-replace in an attempt to fix a couple of flaky tests that were causing CI to fail quite consistently. More details on the issue and pull request above.

I'll try building this 3 times and, if those tests don't fail anymore, I will go ahead and merge it.

Antonio Scandurra
@as-cii

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Alright, it seems like this passed 3 times out of 3, so I'll go ahead and merge.

@as-cii as-cii merged commit 22c578e into master Jun 12, 2019

1 of 2 checks passed

Atom Pull Requests in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@as-cii as-cii deleted the as/update-find-and-replace branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.