Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for atom-application.test.js on CI #19523

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@as-cii
Copy link
Contributor

commented Jun 13, 2019

Fixes #19512

On Azure and Travis, we recently started observing a few test failures in atom-application.test.js.

After staring at those tests for a bit, it doesn't seem like they are failing due to a race condition. Instead, it is possible that these tests are simply timing out due to CI containers sometimes being overloaded and, thus, slower. I tested this hypothesis locally by running tests on a VM while stress-testing the host machine. Tests would eventually have passed, but they timed out before having the chance to do so.

This commit increases the timeout on CI to 10 seconds for AtomApplication tests in an attempt to fix the spurious failures we were observing. This is similar to what we've historically done for renderer process tests (see spec/spec-helper.coffee).

Antonio Scandurra
Increase timeout for atom-application.test.js on CI
On Azure and Travis, we recently started observing a few test failures 
in atom-application.test.js.

After staring at those tests for a bit, it doesn't seem like they are 
failing due to a race condition. Instead, it is possible that these 
tests are simply timing out due to CI containers sometimes being 
overloaded and, thus, slower.  I tested this hypothesis locally by 
running tests on a VM while stress-testing the host machine. Tests would 
eventually have passed, but they  timed out before having the chance to 
do so.

This commit increases the timeout on CI to 10 seconds for 
`AtomApplication` tests in  an attempt to fix the spurious failures we 
were observing. This is similar to what we've historically done for 
renderer process tests (see 
https://github.com/atom/atom/blob/7faea50190a8c6738b6ecee105645ee274a32b6e/spec/spec-helper.coffee#L50).

@as-cii as-cii requested review from jasonrudolph and rafeca Jun 13, 2019

@jasonrudolph jasonrudolph merged commit 7aaf836 into master Jun 13, 2019

2 checks passed

Atom Pull Requests #20190613.4 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jasonrudolph jasonrudolph deleted the as/longer-main-process-tests-timeout branch Jun 13, 2019

jasonrudolph added a commit that referenced this pull request Jun 13, 2019

Merge pull request #19523 from atom/as/longer-main-process-tests-timeout
Increase timeout for atom-application.test.js on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.