Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use organization level templates #19529

Merged
merged 2 commits into from Jun 14, 2019

Conversation

@Arcanemagus
Copy link
Member

commented Jun 13, 2019

Requirements for Contributing Documentation

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only contribute documentation (for example, markdown files or API docs). To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/atom/tree/master/.github/PULL_REQUEST_TEMPLATE.

Description of the Change

Remove the local templates for issues and pull requests in favor of the organization wide ones, meaning we only need to update those for changes. Currently these templates are essentially identical so no changes should be visible in the process.

The only change made that should be visible is that the legacy ISSUE_TEMPLATE.md has been removed, meaning this link will open a blank issue:
image

Since that is now a legacy functionality I don't think this is too big of a change, especially since we would automatically close such an issue anyway for failing to follow the template.

馃毃 鈿狅笍 Warning!!! 鈿狅笍 馃毃
The bit.ly links in PULL_REQUEST_TEMPLATE.md need to be updated to point to the atom/.github locations before this is merged!

Release Notes

N/A


View rendered .github/ISSUE_TEMPLATE/Feature_request.md
View rendered .github/ISSUE_TEMPLATE/bug_report.md
View rendered .github/PULL_REQUEST_TEMPLATE/bug_fix.md
View rendered .github/PULL_REQUEST_TEMPLATE/documentation.md
View rendered .github/PULL_REQUEST_TEMPLATE/feature_change.md
View rendered .github/PULL_REQUEST_TEMPLATE/performance_improvement.md
View rendered CONTRIBUTING.md
View rendered ISSUE_TEMPLATE.md
View rendered PULL_REQUEST_TEMPLATE.md

馃敟 Use organization level templates
Move to the organization level templates for issues and pull requests, 
removing one of the many copies we have floating around.
@Arcanemagus

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

@jasonrudolph It looks like you were the one who originally created those links, assuming this is a direction we want to go with can you update those to point to the organization level templates? Since those files already exist this can be done at any time.

@jasonrudolph
Copy link
Member

left a comment

can you update those to point to the organization level templates?

@Arcanemagus: As far as I can tell, you can't change the target URL for a bit.ly link, so I think we'll have to create new bit.ly links. I've included some suggested edits below to point to new bit.ly links for the pull request templates in the organization-level repo.

CONTRIBUTING.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Apply suggestions from code review
New `bit.ly` links and a change to one of the target templates.

Co-Authored-By: Jason Rudolph <jason@jasonrudolph.com>

@Arcanemagus Arcanemagus marked this pull request as ready for review Jun 14, 2019

@Arcanemagus Arcanemagus merged commit 8430a4a into master Jun 14, 2019

1 check passed

Atom Pull Requests #20190614.7 succeeded
Details

@Arcanemagus Arcanemagus deleted the la/organization-templates branch Jun 14, 2019

@Arcanemagus

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

Confirmed that issues are now using the atom/.github templates after merging, the "Open a regular issue" link behaves as explained, and PR's have the new links in the template message inserted.

@melvisglez

This comment was marked as spam.

Pero qui茅n gu铆a este trabajo?

@melvisglez

This comment was marked as spam.

Estoy buscando insertarme a un proyecto de investigaci贸n. Quiero tener la experiencia de trabajar en "algo" que se vea y se sienta bien.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.